Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] pnp: use %*phC to dump small buffers | Date | Tue, 23 Apr 2013 15:04:50 +0200 |
| |
On Monday, April 22, 2013 04:01:05 PM Andy Shevchenko wrote:
Any changelog?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/pnp/isapnp/core.c | 5 +---- > drivers/pnp/pnpbios/proc.c | 5 ++--- > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c > index 918d5f0..f380bcf 100644 > --- a/drivers/pnp/isapnp/core.c > +++ b/drivers/pnp/isapnp/core.c > @@ -814,10 +814,7 @@ static int __init isapnp_build_device_list(void) > continue; > > #if 0 > - dev_info(&card->dev, > - "vendor: %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n", > - header[0], header[1], header[2], header[3], header[4], > - header[5], header[6], header[7], header[8]); > + dev_info(&card->dev, "vendor: %9phC\n", header); > dev_info(&card->dev, "checksum = %#x\n", checksum); > #endif
I'd rather see that #if 0 block go away entirely.
> INIT_LIST_HEAD(&card->devices); > diff --git a/drivers/pnp/pnpbios/proc.c b/drivers/pnp/pnpbios/proc.c > index 8dafd65..c212db0 100644 > --- a/drivers/pnp/pnpbios/proc.c > +++ b/drivers/pnp/pnpbios/proc.c > @@ -185,10 +185,9 @@ static int pnp_devices_proc_show(struct seq_file *m, void *v) > > if (pnp_bios_get_dev_node(&nodenum, PNPMODE_DYNAMIC, node)) > break; > - seq_printf(m, "%02x\t%08x\t%02x:%02x:%02x\t%04x\n", > + seq_printf(m, "%02x\t%08x\t%3phC\t%04x\n", > node->handle, node->eisa_id, > - node->type_code[0], node->type_code[1], > - node->type_code[2], node->flags); > + node->type_code, node->flags); > if (nodenum <= thisnodenum) { > printk(KERN_ERR > "%s Node number 0x%x is out of sequence following node 0x%x. Aborting.\n", >
Thanks, Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |