lkml.org 
[lkml]   [2013]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[51/75] kernel/signal.c: stop info leak via the tkill and the tgkill syscalls
    3.2.44-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Emese Revfy <re.emese@gmail.com>

    commit b9e146d8eb3b9ecae5086d373b50fa0c1f3e7f0f upstream.

    This fixes a kernel memory contents leak via the tkill and tgkill syscalls
    for compat processes.

    This is visible in the siginfo_t->_sifields._rt.si_sigval.sival_ptr field
    when handling signals delivered from tkill.

    The place of the infoleak:

    int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from)
    {
    ...
    put_user_ex(ptr_to_compat(from->si_ptr), &to->si_ptr);
    ...
    }

    Signed-off-by: Emese Revfy <re.emese@gmail.com>
    Reviewed-by: PaX Team <pageexec@freemail.hu>
    Signed-off-by: Kees Cook <keescook@chromium.org>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    Cc: Serge Hallyn <serge.hallyn@canonical.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    kernel/signal.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/signal.c
    +++ b/kernel/signal.c
    @@ -2790,7 +2790,7 @@ do_send_specific(pid_t tgid, pid_t pid,

    static int do_tkill(pid_t tgid, pid_t pid, int sig)
    {
    - struct siginfo info;
    + struct siginfo info = {};

    info.si_signo = sig;
    info.si_errno = 0;


    \
     
     \ /
      Last update: 2013-04-22 18:21    [W:4.038 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site