Messages in this thread | | | Date | Mon, 22 Apr 2013 17:31:36 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCHv2 2/5] driver: serial: omap: prevent runtime PM for "no_console_suspend" |
| |
Hi,
On Mon, Apr 22, 2013 at 07:13:54PM +0530, Sourav Poddar wrote: > The driver manages "no_console_suspend" by preventing runtime PM > during the suspend path, which forces the console UART to stay awake. > > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> > --- > drivers/tty/serial/omap-serial.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index 08332f3..640b14e 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -1582,7 +1582,7 @@ static int serial_omap_runtime_suspend(struct device *dev) > struct uart_omap_port *up = dev_get_drvdata(dev); > struct omap_uart_port_info *pdata = dev->platform_data; > > - if (!up) > + if (!up || (!console_suspend_enabled && uart_console(&up->port))) > return -EINVAL;
-EBUSY would be a better value for uart_console case, so this check should be splitted accordingly. Likewise on second hunk.
-- balbi [unhandled content-type:application/pgp-signature] | |