lkml.org 
[lkml]   [2013]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] sysrq: fix inconstistent help message of sysrq key
On 2013/3/8 4:14, Randy Dunlap wrote:
> On 03/07/13 01:00, zhangwei(Jovi) wrote:
>> Currently help message of /proc/sysrq-trigger highlight its
>> upper-case characters, like below:
>>
>> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>> memory-full-oom-kill(F) kill-all-tasks(I) ...
>>
>> this would confuse user trigger sysrq by upper-case character, which is
>> inconsistent with the real lower-case character registed key.
>>
>> This inconsistent help message will also lead more confused when
>> 26 upper-case letters put into use in future.
>>
>> This patch fix it.
>>
>> Thanks the comments from Andrew and Randy.
>>
>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>
> for the patch series (1-8):
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
Andrew, Could you pick up the other patches(2,3,4,5,7,8) into your -mm tree?
first patch was already merged by Grey.

Thanks.







\
 
 \ /
  Last update: 2013-04-22 14:21    [W:0.086 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site