Messages in this thread | | | Date | Sun, 21 Apr 2013 20:22:27 +0200 | From | Borislav Petkov <> | Subject | Re: [tip:perf/core] perf/x86/amd: Add support for AMD NB and L2I " uncore" counters |
| |
On Sun, Apr 21, 2013 at 01:06:27PM -0500, Jacob Shin wrote: > From 2ac60428e58f7bfd7dec4baa772f523eeedfecc6 Mon Sep 17 00:00:00 2001 > From: Jacob Shin <jacob.shin@amd.com> > Date: Sun, 21 Apr 2013 12:58:21 -0500 > Subject: [PATCH 1/1] perf, amd: fix lockdep warning, don't __GFP_FS alloc > with IRQs disabled > > Fix lockdep warning by not calling kzalloc in smp_call_function_single.
This should say something about "do not allocate memory in the IRQ handler or so." And I think the flag is __GFP_WAIT. Look at allocate_slab() in slub.c:
if (flags & __GFP_WAIT) local_irq_enable();
The local_irq_enable() calls into lockdep with trace_hardirqs_on().
Other than that:
Tested-by: Borislav Petkov <bp@suse.de>
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |