Messages in this thread | | | Date | Tue, 02 Apr 2013 09:21:26 -0600 | From | David Ahern <> | Subject | Re: [PATCH 20/23] perf: consolidate CONFIG_LIBELF checks in Makefile |
| |
On 4/2/13 3:37 AM, Paul Bolle wrote: > On Mon, 2013-04-01 at 21:54 -0600, David Ahern wrote: >> --- a/tools/perf/Makefile >> +++ b/tools/perf/Makefile >> [...] >> @@ -602,6 +590,16 @@ ifdef CONFIG_LIBELF >> endif >> >> else >> + ifdef CONFIG_DWARF >> + $(error CONFIG_DWARF depends on LIBELF) >> + endif >> + ifdef CONFIG_DEMANGLE >> + $(error CONFIG_DEMANGLE depends on LIBELF) >> + endif >> + ifdef CONFIG_LIBUNWIND >> + $(error CONFIG_LIBUNWIND depends on LIBELF) >> + endif >> + >> EXTLIBS := $(filter-out -lelf,$(EXTLIBS)) >> >> # Remove ELF/DWARF dependent codes > > A quick scan of your series suggests you check here for dependencies > that are already enforced by the kconfig tools. Why is this needed?
Just a side effect of the evolutionary path from where the perf build is today to the kconfig route. Certainly the above (and similar ones) are not needed in the end.
David
| |