lkml.org 
[lkml]   [2013]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH wireless-next V2] rt2x00: Use more current logging styles, shrink object size
On 04/19/13 17:33, Joe Perches wrote:
> Reduce object space ~2% using more current logging styles.
>
> Neaten and simplify logging macros.
> Use wiphy_<level> where appropriate.
> Coalesce formats.
>
> Convert ERROR/WARNING/INFO macros to rt2x00_<level>
> Convert EEPROM to rt2x00_eeprom_dbg
> Convert PROBE_ERROR to rt2x00_probe_err
> Convert DEBUG to rt2x00_dbg
> Convert EEPROM to rt2x00_eeprom_dbg
>
> $ size drivers/net/wireless/rt2x00/built-in.o*
> text data bss dec hex filename
> 245639 71696 69584 386919 5e767 drivers/net/wireless/rt2x00/built-in.o.new
> 240609 70096 68944 379649 5cb01 drivers/net/wireless/rt2x00/built-in.o.new.nodyndbg
> 240609 70096 68944 379649 5cb01 drivers/net/wireless/rt2x00/built-in.o.new.no_rt2x00_debug
> 249198 70096 70352 389646 5f20e drivers/net/wireless/rt2x00/built-in.o.old
> 249198 70096 70352 389646 5f20e drivers/net/wireless/rt2x00/built-in.o.old.nodyndbg
> 244222 70096 69712 384030 5dc1e drivers/net/wireless/rt2x00/built-in.o.old.no_rt2x00_debug
>
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

> ---
> V2 differences:
>
> Correct copy/paste error in rt2x00_info/warn macros
> Reorder macro definitions
> Use embedded prefix in rt2x00_eeprom_dbg
>
> Object size increased from v1 ~100 bytes x86/32.
> Object size may be slightly smaller this way for x86/64
>
>
---
Gertjan


\
 
 \ /
  Last update: 2013-04-19 21:01    [W:0.053 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site