Messages in this thread | | | Date | Thu, 18 Apr 2013 01:24:14 -0700 | Subject | Re: [PATCH V2] scsi: ufs: add support for query requests | From | "Dolev Raviv" <> |
| |
Hi All,
A minor bug was spotted, as shown blow. The fix will be submitted with the next version.
> +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb > *lrbp) > +{ > + u32 upiu_flags; > + int ret = 0; > + > + if (!lrbp) { > + dev_err(hba->dev, "%s: lrbp can not be NULL\n", __func__); > + ret = -EINVAL; > + } else if (!lrbp->ucd_req_ptr) { > + dev_err(hba->dev, "%s: ucd_req_ptr can not be NULL\n", > + __func__); > + ret = -EINVAL; > + } else if (!lrbp->utr_descriptor_ptr) { > + dev_err(hba->dev, "%s: utr_descriptor_ptr can not be NULL\n", > + __func__); > + ret = -EINVAL; > + } > + if (!ret) > + goto exit; should be: if (ret)
Thanks, Dolev
-- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |