Messages in this thread | | | Date | Thu, 18 Apr 2013 06:35:55 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/4] mfd: Kontron PLD mfd driver |
| |
On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: > On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > > index + 1) > > > Please > > Wondering .... why does checkpatch not report those ? > > because checkpatch doesn't care about spacing around > arithmetic as long as it's consistent. > > Documentation/CodingStyle doesn't say anything about > it either. > Hi Joe,
"Use one space around (on each side of) most binary and ternary operators"
doesn't apply, then ? When does it apply ? I always thought it would apply to cases such as the above.
Thanks, Guenter
| |