lkml.org 
[lkml]   [2013]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] HID: appleir: add support for Apple ir devices
    On 04/17/2013 12:30 PM, Oliver Neukum wrote:
    > On Wednesday 17 April 2013 11:03:09 Benjamin Tissoires wrote:
    >
    >> +static void appleir_remove(struct hid_device *hid)
    >> +{
    >> + struct appleir *appleir = hid_get_drvdata(hid);
    >> + del_timer_sync(&appleir->key_up_timer);
    >> + hid_hw_stop(hid);
    >> + kfree(appleir);
    >> +}
    >
    > Hi,
    >
    > this looks like a race condition. If you get input between
    > del_timer_sync() and hid_hw_stop() the timer may be restarted.
    > You need to stop the hw first.
    >

    ouch. Thanks for spotting this.
    Will send a v3 soon.

    Cheers,
    Benjamin



    \
     
     \ /
      Last update: 2013-04-17 18:41    [W:4.494 / U:0.900 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site