Messages in this thread | | | Date | Fri, 12 Apr 2013 11:33:23 +0200 | From | Bengt Jönsson <> | Subject | Re: [RFT][PATCH] regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO |
| |
On 04/12/2013 09:33 AM, Axel Lin wrote: > The voltage_mask and voltage_shift settings of AB8505_LDO_AUDIO are not matched. > It looks like a typo in the voltage_mask settings. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > Hi Lee and Bengt, > I don't have the datasheet. Can you confirm if this fix is correct? > > Thanks, > Axel Yes it is correct. The voltage bits are in 0x70. Thank you!
Acked-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com> > drivers/regulator/ab8500.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c > index ea182d3..b81ff04 100644 > --- a/drivers/regulator/ab8500.c > +++ b/drivers/regulator/ab8500.c > @@ -1130,7 +1130,7 @@ static struct ab8500_regulator_info > .update_val = 0x02, > .voltage_bank = 0x01, > .voltage_reg = 0x57, > - .voltage_mask = 0x7, > + .voltage_mask = 0x70, > .voltage_shift = 4, > }, > [AB8505_LDO_ANAMIC1] = {
| |