Messages in this thread | | | Date | Fri, 12 Apr 2013 11:12:35 +0200 | From | Christian Ruppert <> | Subject | Re: [PATCH] clk: Add device tree binding to clk-fixed-factor |
| |
On Fri, Apr 12, 2013 at 11:04:51AM +0200, Gregory CLEMENT wrote: > On 04/12/2013 08:54 AM, Christian Ruppert wrote: > > On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: > >> On 04/11/2013 11:19 AM, Christian Ruppert wrote: > >>> Hi Gregory, > >>> > >>> Since there doesn't seem to be anyone opposing this feature I just > >>> checked your patch and after adding the CLK_OF_DECLARE macro in the end > >>> it works well for us. Tell me if you would like to rebase and resubmit > >>> your patch or if I should follow up on our own. > >> > >> I can rebase and resubmit my patch, it's pretty straightforward. > >> The problem was the lack of user in the kernel. And by user I mean > >> a driver using these functions. Usually a new function enter in the > >> kernel only if there are users for it inside the kernel so if you plan > >> to submit a driver using this piece of code, then I see no reason > >> to not get it. > > > > If you add the line > > > > CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clkdiv", > > Why did you add the div suffix? > > There is nothing in the function which prevent to have "mul" greater than > "div" and hence having a multiplicative factor. > > I think that this suffix is misleading.
You are right, let's remove it.
> [...]
-- Christian Ruppert , <christian.ruppert@abilis.com> /| Tel: +41/(0)22 816 19-42 //| 3, Chemin du Pré-Fleuri _// | bilis Systems CH-1228 Plan-les-Ouates -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |