lkml.org 
[lkml]   [2013]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: usb: active URB submitted multiple times
From
From: Petko Manolov <petkan@nucleusys.com>
Date: Thu, 11 Apr 2013 22:00:59 +0300 (EEST)

> From: Petko Manolov <petkan@nucleusys.com>
>
> (For inclusion in 3.10, diff against latest net-next.)
>
> Pegasus driver used single callback for sync and async control URBs.
> Special flags were employed to distinguish between both, but due to flawed
> logic (as Sarah Sharp spotted) it didn't always work. As a result of this
> change [get|set]_registers() are now much simpler. Async write is also
> leaner and does not use single, statically allocated memory for
> usb_ctrlrequest, which is another potential race when asynchronously
> submitting URBs.
>
> The socket buffer pool for the receive path is now gone. It's existence
> didn't make much difference (performance-wise) and the code is better off
> without the spinlocks protecting it.
>
> Largely duplicated code in routines reading and writing MII registers is
> now packed in __mii_op().
>
> Adding URL for the public pegasus git repository.
>
> Signed-off-by: Petko Manolov <petkan@nucleusys.com>

When submitting a new version of a patch, you must list what
changed from the previous version after the "---" delimiter
rather than having people try and guess.

> +T: git git://petkan@git.code.sf.net/p/pegasus2/git

There is no way that specifying your GIT login in this URL
meant for public use is correct, or is it?


\
 
 \ /
  Last update: 2013-04-12 21:41    [W:0.540 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site