Messages in this thread | | | Date | Fri, 12 Apr 2013 15:05:46 -0400 (EDT) | Subject | Re: [PATCH v2] net: mv643xx_eth: remove deprecated inet_lro support | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Fri, 12 Apr 2013 05:55:39 -0700
> On Fri, 2013-04-12 at 11:20 +0200, Sebastian Hesselbarth wrote: >> With recent support for GRO, there is no need to keep both LRO and >> GRO. This patch therefore removes the deprecated inet_lro support >> from mv643xx_eth. This is work is based on an experimental patch >> provided by Eric Dumazet and Willy Tarreau. >> >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> >> Based-on-patch-by: Eric Dumazet <eric.dumazet@gmail.com> >> Based-on-patch-by: Willy Tarreau <w@1wt.eu> >> --- >> Changes from v1: >> - also remove INET_LRO from Kconfig (Reported by Eric Dumazet) > > Thanks for finishing this patch > > Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, but this driver is full of skeletons:
drivers/net/ethernet/marvell/mv643xx_eth.c: In function ‘rxq_refill’: drivers/net/ethernet/marvell/mv643xx_eth.c:618:19: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)
which is:
size = skb->end - skb->data;
that is absolutely not a legal computation.
It happens to be in the only configuration for which this driver can be enabled in Kconfig but that is no excuse for it :-)
| |