lkml.org 
[lkml]   [2013]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RT v2] x86/mce: Defer mce wakeups to threads for PREEMPT_RT
From
Date
On Fri, 2013-04-12 at 15:38 +0200, Borislav Petkov wrote:

> > +static void __mce_notify_work(void)
> > +{
> > + /* Not more than two messages every minute */
> > + static DEFINE_RATELIMIT_STATE(ratelimit, 60*HZ, 2);
> > +
> > + /* wake processes polling /dev/mcelog */
> > + wake_up_interruptible(&mce_chrdev_wait);
> > +
> > + /*
> > + * There is no risk of missing notifications because
> > + * work_pending is always cleared before the function is
> > + * executed.
> > + */
>
> You must be using some tree != mainline because this comment is gone
> upstream and that whole second hunk below which moves it here doesn't
> apply.
>

I forgot to state that I based this off of 3.6-rt, and will be
backporting it to 3.0-rt as that's the kernel that the bug was reported
on. But the problem still exists in mainline as well (for -rt).

-- Steve




\
 
 \ /
  Last update: 2013-04-12 16:01    [W:0.088 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site