lkml.org 
[lkml]   [2013]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 21/22] x86, mm: Make init_mem_mapping be able to be called several times
From
On Thu, Apr 11, 2013 at 6:05 PM, Konrad Wilk <konrad.wilk@oracle.com> wrote:
>
> ----- yinghai@kernel.org wrote:
>
>> Prepare to put page table on local nodes.
>>
>> Move calling of init_mem_mapping to early_initmem_init.
>>
>> Rework alloc_low_pages to alloc page table in following order:
>> BRK, local node, low range
>>
>> Still only load_cr3 one time, otherwise we would break xen 64bit
>> again.
>
> I have asked you in the previous iteration of the patch to fix that comment.

Maybe it is not clear enough.

>
> Please remove it - as it is misleading. The issue with load_cr3 more than
> once has been fixed under the Xen platform.

Peter, can you remove those two lines?
or need to resend -v5?

Thanks

Yinghai


\
 
 \ /
  Last update: 2013-04-12 04:21    [W:0.025 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site