lkml.org 
[lkml]   [2013]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 169/171 ] pch_gbe: fix ip_summed checksum reporting on rx
    3.6.11.2 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Veaceslav Falico <vfalico@redhat.com>

    [ Upstream commit 76a0e68129d7d24eb995a6871ab47081bbfa0acc ]

    skb->ip_summed should be CHECKSUM_UNNECESSARY when the driver reports that
    checksums were correct and CHECKSUM_NONE in any other case. They're
    currently placed vice versa, which breaks the forwarding scenario. Fix it
    by placing them as described above.

    Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
    index feb85d5..bfc2d64 100644
    --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
    +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
    @@ -1777,9 +1777,9 @@ pch_gbe_clean_rx(struct pch_gbe_adapter *adapter,

    skb->protocol = eth_type_trans(skb, netdev);
    if (tcp_ip_status & PCH_GBE_RXD_ACC_STAT_TCPIPOK)
    - skb->ip_summed = CHECKSUM_NONE;
    - else
    skb->ip_summed = CHECKSUM_UNNECESSARY;
    + else
    + skb->ip_summed = CHECKSUM_NONE;

    napi_gro_receive(&adapter->napi, skb);
    (*work_done)++;
    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-04-12 03:01    [W:4.018 / U:0.584 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site