Messages in this thread Patch in this message | | | From | Frederic Weisbecker <> | Subject | [PATCH 3/5] sched: Update rq clock before calling check_preempt_curr() | Date | Fri, 12 Apr 2013 01:51:00 +0200 |
| |
check_preempt_curr() of fair class needs an uptodate sched clock value to update runtime stats of the current task of the target's rq.
When a task is woken up, activate_task() is usually called right before ttwu_do_wakeup() unless the task is still in the runqueue. In the latter case we need to update the rq clock explicitly because activate_task() isn't here to do the job for us.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Li Zhong <zhong@linux.vnet.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Paul Turner <pjt@google.com> Cc: Mike Galbraith <efault@gmx.de> --- kernel/sched/core.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ec036d8..5f3e05d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1334,6 +1334,8 @@ static int ttwu_remote(struct task_struct *p, int wake_flags) rq = __task_rq_lock(p); if (p->on_rq) { + /* check_preempt_curr() may use rq clock */ + update_rq_clock(rq); ttwu_do_wakeup(rq, p, wake_flags); ret = 1; } -- 1.7.5.4
| |