lkml.org 
[lkml]   [2013]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 090/171 ] b43: N-PHY: use more bits for offset in RSSI calibration
    3.6.11.2 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>

    [ Upstream commit 2e1253d640eb7f8707d2591c93097c1e9f9c71d5 ]

    When calculating "offset" for final RSSI calibration we're using numbers
    bigger than s8 can hold. We have for example:
    offset[j] = 232 - poll_results[j];
    formula. If poll_results[j] is small enough (it usually is) we treat
    number's bit as a sign bit. For example 232 - 1 becomes:
    0xE8 - 0x1 = 0xE7, which is not 231 but -25.

    This code was introduced in e0c9a0219a8f542e3946fe972a68aacf8c3f906c
    and caused stability regression on some cards, for ex. BCM4322.

    Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    drivers/net/wireless/b43/phy_n.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
    index e167a88..914718a 100644
    --- a/drivers/net/wireless/b43/phy_n.c
    +++ b/drivers/net/wireless/b43/phy_n.c
    @@ -1320,7 +1320,7 @@ static void b43_nphy_rev3_rssi_cal(struct b43_wldev *dev)
    u16 clip_off[2] = { 0xFFFF, 0xFFFF };

    u8 vcm_final = 0;
    - s8 offset[4];
    + s32 offset[4];
    s32 results[8][4] = { };
    s32 results_min[4] = { };
    s32 poll_results[4] = { };
    @@ -1488,7 +1488,7 @@ static void b43_nphy_rev2_rssi_cal(struct b43_wldev *dev, u8 type)
    u8 regs_save_radio[2];
    u16 regs_save_phy[2];

    - s8 offset[4];
    + s32 offset[4];
    u8 core;
    u8 rail;

    --
    1.7.10.4

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-04-12 00:21    [W:4.462 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site