lkml.org 
[lkml]   [2013]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 134/171 ] usb: gadget: udc-core: fix a regression during gadget driver unbinding
    3.6.11.2 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Alan Stern <stern@rowland.harvard.edu>

    [ Upstream commit 511f3c5326eabe1ece35202a404c24c0aeacc246 ]

    This patch (as1666) fixes a regression in the UDC core. The core
    takes care of unbinding gadget drivers, and it does the unbinding
    before telling the UDC driver to turn off the controller hardware.
    When the call to the udc_stop callback is made, the gadget no longer
    has a driver. The callback routine should not be invoked with a
    pointer to the old driver; doing so can cause problems (such as
    use-after-free accesses in net2280).

    This patch should be applied, with appropriate context changes, to all
    the stable kernels going back to 3.1.

    Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
    CC: <stable@vger.kernel.org>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    drivers/usb/gadget/udc-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
    index e5e44f8..b0af333 100644
    --- a/drivers/usb/gadget/udc-core.c
    +++ b/drivers/usb/gadget/udc-core.c
    @@ -265,7 +265,7 @@ static void usb_gadget_remove_driver(struct usb_udc *udc)
    udc->driver->disconnect(udc->gadget);
    usb_gadget_disconnect(udc->gadget);
    udc->driver->unbind(udc->gadget);
    - usb_gadget_udc_stop(udc->gadget, udc->driver);
    + usb_gadget_udc_stop(udc->gadget, NULL);
    } else {
    usb_gadget_stop(udc->gadget, udc->driver);
    }
    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-04-12 00:01    [W:4.072 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site