Messages in this thread | | | Date | Thu, 11 Apr 2013 12:05:31 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC] |
| |
On Thu, Apr 11, 2013 at 04:15:52PM +0100, David Howells wrote: > Ian Abbott <abbotti@mev.co.uk> wrote: > > > > Don't use create_proc_read_entry() as that is deprecated, but rather use > > > proc_create_data() and seq_file instead. > > > > It seems to work okay and is simpler than I thought it would be! You changed > > the mode of the file to 0644 for some reason though. Please change it back to > > 0444 or S_IFREG | S_IRUGO. Thanks. > > Ah... cut'n'paste error. Sorry about that.
I can fix that up by hand when I apply it, no worries.
thanks,
greg k-h
| |