Messages in this thread | | | Date | Thu, 11 Apr 2013 14:29:44 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 4/5] break up slow_virt_to_phys() |
| |
On Wed, Apr 10, 2013 at 04:32:54PM -0700, Dave Hansen wrote: > +phys_addr_t slow_virt_to_phys(void *virt_addr) > +{ > + phys_addr_t result; > + int ret; > + > + ret = kernel_lookup_vaddr(virt_addr, &result); > + BUG_ON(ret);
Isn't that BUG_ON still too harsh though? How about WARN_ON instead? It would still create a lot of noise so that it gets fixed without bringing down the system.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |