Messages in this thread | | | Date | Thu, 11 Apr 2013 11:53:33 +0200 | From | Sylwester Nawrocki <> | Subject | Re: [PATCH 1/2] mfd: wm8994: Add device ID data to WM8994 OF device IDs |
| |
On 04/10/2013 04:39 PM, Mark Brown wrote: > We can actually read this back from the device but we use this when > registered using standard I2C board data registration so make sure > it's there for OF too. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > > Untested at present.
I have tested this with wm1811 codec, together with the second patch. The device type was set correctly.
FWIW, Tested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> drivers/mfd/wm8994-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c > index cdea84e..3f8d591 100644 > --- a/drivers/mfd/wm8994-core.c > +++ b/drivers/mfd/wm8994-core.c > @@ -673,9 +673,9 @@ static void wm8994_device_exit(struct wm8994 *wm8994) > } > > static const struct of_device_id wm8994_of_match[] = { > - { .compatible = "wlf,wm1811", }, > - { .compatible = "wlf,wm8994", }, > - { .compatible = "wlf,wm8958", }, > + { .compatible = "wlf,wm1811", .data = (void *)WM1811 }, > + { .compatible = "wlf,wm8994", .data = (void *)WM8994 }, > + { .compatible = "wlf,wm8958", .data = (void *)WM8958 }, > { } > }; > MODULE_DEVICE_TABLE(of, wm8994_of_match);
Thanks, Sylwester
| |