Messages in this thread | | | Date | Wed, 10 Apr 2013 13:41:24 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] mm: Simplify for_each_populated_zone() |
| |
On Thu, 11 Apr 2013, Srivatsa S. Bhat wrote:
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index ede2749..2489042 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -948,9 +948,7 @@ extern struct zone *next_zone(struct zone *zone); > for (zone = (first_online_pgdat())->node_zones; \ > zone; \ > zone = next_zone(zone)) \ > - if (!populated_zone(zone)) \ > - ; /* do nothing */ \ > - else > + if (populated_zone(zone)) > > static inline struct zone *zonelist_zone(struct zoneref *zoneref) > {
Nack, it's written the way it is to avoid ambiguous else statements following it. People do things like
for_each_populated_zone(z) if (...) { } else (...) { }
and it's now ambiguous (and should warn with -Wparentheses).
| |