Messages in this thread Patch in this message | | | Date | Wed, 10 Apr 2013 15:10:50 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2 0/7] sched: Split cpuacct |
| |
* Ingo Molnar <mingo@kernel.org> wrote:
> > * Peter Zijlstra <peterz@infradead.org> wrote: > > > On Fri, 2013-03-29 at 14:36 +0800, Li Zefan wrote: > > > > > - This patchset splits cpuacct out of core scheduler code. > > > - Plus two small optimizations. > > > > > > > > --- > > > kernel/sched/Makefile | 1 + > > > kernel/sched/core.c | 228 +---------------------------------------------- > > > kernel/sched/cpuacct.c | 303 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > kernel/sched/cpuacct.h | 22 +++++ > > > kernel/sched/cputime.c | 18 +--- > > > kernel/sched/sched.h | 48 +--------- > > > 6 files changed, 330 insertions(+), 290 deletions(-) > > > > Looks good from a quick glance, thanks for doing this. > > > > Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Looks good to me too, so I added it to tip:sched/core. > > The only breakage it cased was on UML: > > home/mingo/tip/kernel/sched/cpuacct.c:94:2: error: implicit declaration of > function 'ERR_PTR' [-Werror=implicit-function-declaration] > > I suspect it's a previously hidden header file dependency assumption and the patch > below will fix it.
diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c index ef57ab6..dbb7e2c 100644 --- a/kernel/sched/cpuacct.c +++ b/kernel/sched/cpuacct.c @@ -6,6 +6,7 @@ #include <linux/seq_file.h> #include <linux/rcupdate.h> #include <linux/kernel_stat.h> +#include <linux/err.h> #include "sched.h"
| |