lkml.org 
[lkml]   [2013]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: USB: mos7840: looping issue: avoid the return value overriden by looping
On Mon, Apr 01, 2013 at 11:50:55AM +0800, Chen Gang wrote:
>
> inside the 'for' looping:
> the return value 'rv' may override if not have a check in time.
>
> next checking, outside the 'for' looping:
> can not find failure which generated during the 'for' looping
>
> so need let outside know about the failure.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/usb/serial/mos7840.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index a0d5ea5..13aae1e 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -651,7 +651,9 @@ static void mos7840_interrupt_callback(struct urb *urb)
> wreg = MODEM_STATUS_REGISTER;
> break;
> }
> - rv = mos7840_get_reg(mos7840_port, wval, wreg, &Data);
> + if (mos7840_get_reg(mos7840_port, wval,
> + wreg, &Data) < 0)
> + rv = -1;

Please use a "real" error value, or even better yet, use the error value
returned from the call here.

And please identify the driver you are modifying in the Subject: line,
like I have changed this one to.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-04-01 22:21    [W:0.051 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site