lkml.org 
[lkml]   [2013]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/7] kernel/sys.c: Use the simpler call_usermodehelper()
    On 03/08, Lucas De Marchi wrote:
    >
    > Commit "7ff6764 usermodehelper: cleanup/fix __orderly_poweroff() &&
    > argv_free()" simplified __orderly_poweroff() removing the need to use
    > call_usermodehelper_fns().
    >
    > Since we are not passing any callback, it's simpler to use
    > call_usermodehelper().
    >
    > Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>

    Reviewed-by: Oleg Nesterov <oleg@redhat.com>

    > ---
    > kernel/sys.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/kernel/sys.c b/kernel/sys.c
    > index 81f5644..bd15276 100644
    > --- a/kernel/sys.c
    > +++ b/kernel/sys.c
    > @@ -2203,8 +2203,7 @@ static int __orderly_poweroff(void)
    > return -ENOMEM;
    > }
    >
    > - ret = call_usermodehelper_fns(argv[0], argv, envp, UMH_WAIT_EXEC,
    > - NULL, NULL, NULL);
    > + ret = call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC);
    > argv_free(argv);
    >
    > return ret;
    > --
    > 1.8.1.5
    >



    \
     
     \ /
      Last update: 2013-03-09 22:01    [W:2.417 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site