Messages in this thread | | | Date | Sat, 09 Mar 2013 04:01:06 +0100 | From | Daniel Lezcano <> | Subject | Re: [PATCH 1/3] intel_idle: changing the continue to break in intel_idle_cpu_init() |
| |
On 03/08/2013 04:03 PM, Chuansheng Liu wrote: > > According to commit e022e7eb9, the .enter == NULL is the last one in > state_tables[]. > > So just like intel_idle_cpuidle_driver_init(), in case of .enter == NULL, > breaking the for(;;) loop directly. > > Signed-off-by: liu chuansheng <chuansheng.liu@intel.com> > ---
Sounds good.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> drivers/idle/intel_idle.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > index 5d66750..17c9cf9 100644 > --- a/drivers/idle/intel_idle.c > +++ b/drivers/idle/intel_idle.c > @@ -610,7 +610,7 @@ static int intel_idle_cpu_init(int cpu) > int num_substates, mwait_hint, mwait_cstate, mwait_substate; > > if (cpuidle_state_table[cstate].enter == NULL) > - continue; > + break; > > if (cstate + 1 > max_cstate) { > printk(PREFIX "max_cstate %d reached\n", max_cstate); >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |