lkml.org 
[lkml]   [2013]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]
On Wed, Mar 06, 2013 at 02:14:56PM -0500, Peter Hurley wrote:
> On Wed, 2013-03-06 at 17:52 +0100, Johan Hovold wrote:
>
> > > > @@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port)
> > > spin_lock_irqsave(&port->lock, flags);
> > > port->count = 0;
> > > port->flags &= ~ASYNC_NORMAL_ACTIVE;
> > > - if (port->tty) {
> > > + if (port->tty)
> > > set_bit(TTY_IO_ERROR, &port->tty->flags);
> > > - tty_kref_put(port->tty);
> > > - }
> > > - port->tty = NULL;
> > > spin_unlock_irqrestore(&port->lock, flags);
> > > > + tty_port_shutdown(port, port->tty);
> > >
> > > What prevents port->tty to be NULL here already?
> >
> > Nothing, I'll get a new reference within the port lock section as you
> > just suggested elsewhere in this thread.
>
> Don't do that. Steal the tty and put the kref after like this:

Allright.

> > Yes, I did. First, the order should not matter for blocked opens as they
> > will exit their wait loops based on tty_hung_up_p(filp) either way.
>
> Only if the open() was ever successful, otherwise the filp won't be in
> the tty->tty_files list. That's why the blocking opens also check
> ASYNC_INITIALIZED (or ASYNCB_INITIALIZED depending on which they use).
> Which is why I said it was actually better to shutdown() first, then
> wake up the blocked opens.

ASYNC_INITIALIZED have also been cleared when the blocked opens are
being woken up from tty_port_close_end.

And the filp is added to tty_files before open() is called:

===> tty_add_file(tty, filp);

check_tty_count(tty, __func__);
if (tty->driver->type == TTY_DRIVER_TYPE_PTY &&
tty->driver->subtype == PTY_TYPE_MASTER)
noctty = 1;
#ifdef TTY_DEBUG_HANGUP
printk(KERN_DEBUG "%s: opening %s...\n", __func__, tty->name);
#endif
if (tty->ops->open)
===> retval = tty->ops->open(tty, filp);

so a blocked open must have hung_up_tty_fops when woken up from hangup,
right?

Either way, postponing wake-up somewhat in tty_port_hangup should be
fine.

Thanks,
Johan


\
 
 \ /
  Last update: 2013-03-07 11:21    [W:0.094 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site