Messages in this thread | | | Subject | Re: [PATCH] sched: wakeup buddy | From | Peter Zijlstra <> | Date | Thu, 07 Mar 2013 18:21:57 +0100 |
| |
On Wed, 2013-03-06 at 15:06 +0800, Michael Wang wrote: > +static inline int wakeup_related(struct task_struct *p) > +{ > + if (wakeup_buddy(p, current)) { > + /* > + * Now check whether current still focus on his buddy. > + */ > + if (wakeup_buddy(current, p)) > + return 1; > + } > + > + return 0; > +}
Not commenting on the thing in general, but:
static inline bool wakeup_related(struct task_struct *p) { return wakeup_buddy(p, current) && wakeup_buddy(current, p); }
is far shorter and easier to read :-)
| |