Messages in this thread | | | Date | Thu, 7 Mar 2013 15:53:50 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [RFC 1/2] HID: Extend the interface with idle requests |
| |
On Thu, 7 Mar 2013, Benjamin Tissoires wrote:
> >> +static int usbhid_idle(struct hid_device *hid, int report, int idle, > >> + int reqtype) > > > > Where does the need for passing the report argument come from please? > > Well, I haven't checked in the USB spec, but hid_set_idle() in > usbhid/hid-core.c does require the reportID, so I add it to the > request. > I just gave a quick look at the HID/I2C spec, and it also requires the > report ID. The set_idle request is report specific.
You are right, I have missed the special meaning of lower byte of wValue.
Okay, I think it makes sense. I will be taking the patches.
Thanks Benjamin.
-- Jiri Kosina SUSE Labs
| |