lkml.org 
[lkml]   [2013]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] usb: musb: ux500: add otg notifier support
On Wed, Mar 06, 2013 at 10:54:46AM +0200, Felipe Balbi wrote:
> > > are you sure this is correct ? you're not doing anything in case of
> > > vbus event. Shouldn't you make sure your vbus is off ?
> >
> > The implementation I'm taking as reference for this patches does not do
> > anything on VBUS event and as I can see from commmit history, it has
> > been based on the omap2430 one, that in turns used to just run phy_init
> > - and that's not implemented. But...
> >
> > > What if your user uses a non-standard cable which has id-pin grounded
> > > on both sides ?
> >
> > A cable with two micro/mini connectors with grounded IDs? Did you ever
> > encountered such a thing? I guess a ux500_musb_set_vbus(musb, 0) would
>
> in fact, no...
>
> > not hurt in that case.
>
> right, just to be sure. Maybe I should fix omap2430 as well. I'll add it
> to my TODO list.

Fair enough, I'll send a v2 of this patch with the added vbus-off as
soon as I manage to test it.

Thanks,
Fabio

--
Fabio Baltieri


\
 
 \ /
  Last update: 2013-03-07 03:41    [W:0.041 / U:3.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site