Messages in this thread | | | From | Lars Poeschel <> | Subject | Re: [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val | Date | Wed, 6 Mar 2013 11:38:21 +0100 |
| |
On Tuesday 05 March 2013 at 13:21:56, Axel Lin wrote: > Set it once is enough, and it's done in vprbrd_gpiob_set() which is called > by vprbrd_gpiob_direction_output(). > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thank you!
Tested-and-Acked-by: Lars Poeschel <poeschel@lemonage.de>
> --- > drivers/gpio/gpio-viperboard.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpio/gpio-viperboard.c > b/drivers/gpio/gpio-viperboard.c index 59d7239..095ab14 100644 > --- a/drivers/gpio/gpio-viperboard.c > +++ b/drivers/gpio/gpio-viperboard.c > @@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct > gpio_chip *chip, struct vprbrd *vb = gpio->vb; > > gpio->gpiob_out |= (1 << offset); > - if (value) > - gpio->gpiob_val |= (1 << offset); > - else > - gpio->gpiob_val &= ~(1 << offset); > > mutex_lock(&vb->lock);
| |