lkml.org 
[lkml]   [2013]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH v2 04/20] vmcore: allocate buffer for ELF headers on page-size alignment
From
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v2 04/20] vmcore: allocate buffer for ELF headers on page-size alignment
Date: Wed, 6 Mar 2013 14:57:50 +0800

> 于 2013年03月02日 16:36, HATAYAMA Daisuke 写道:
>> Allocate buffer for ELF headers on page-size aligned boudary to
>> satisfy mmap() requirement. For this, __get_free_pages() is used
>> instead of kmalloc().
>>
>> Also, later patch will decrease actually used buffer size for ELF
>> headers, so it's necessary to keep original buffer size and actually
>> used buffer size separately. elfcorebuf_sz_orig keeps the original one
>> and elfcorebuf_sz the actually used one.
>>
>> Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
>> ---
>>
>> fs/proc/vmcore.c | 30 +++++++++++++++++++++---------
>> 1 files changed, 21 insertions(+), 9 deletions(-)
>>

....

>> @@ -665,26 +671,31 @@ static int __init parse_crash_elf32_headers(void)
>>
>> /* Read in all elf headers. */
>> elfcorebuf_sz = ehdr.e_phoff + ehdr.e_phnum * sizeof(Elf32_Phdr);
>> - elfcorebuf = kmalloc(elfcorebuf_sz, GFP_KERNEL);
>> + elfcorebuf_sz_orig = elfcorebuf_sz;
>> + elfcorebuf = (void *) __get_free_pages(GFP_KERNEL | __GFP_ZERO,
>> + get_order(elfcorebuf_sz));
>
> Why not elfcorebuf_sz_orig here?
>

Thanks. I'll fix this.

Thanks.
HATAYAMA, Daisuke



\
 
 \ /
  Last update: 2013-03-06 11:01    [W:0.246 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site