lkml.org 
[lkml]   [2013]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] lglock: update lockdep annotations to report recursive local locks
From
On Tue, Mar 5, 2013 at 9:42 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 03/04, Michel Lespinasse wrote:
>>
>> Both issues are easily fixed by indicating to lockdep that lglock's local
>> locks are not recursive. We shouldn't use the rwlock acquire/release
>> functions here, as lglock doesn't share the same semantics. Instead
>> we can base our lockdep annotations on the lock_acquire_shared
>> (for local lglock) and lock_acquire_exclusive (for global lglock)
>> helpers.
>
> IOW, with this patch lglock looks like rw_semaphore for lockdep...

Yes.

I could have actually made lglock use the rwsem helpers, but I think
that would be quite confusing...

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.


\
 
 \ /
  Last update: 2013-03-05 20:01    [W:1.089 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site