Messages in this thread | | | Date | Tue, 5 Mar 2013 10:24:42 -0800 | Subject | Re: [PATCH 2/2] lglock: update lockdep annotations to report recursive local locks | From | Michel Lespinasse <> |
| |
On Tue, Mar 5, 2013 at 9:42 AM, Oleg Nesterov <oleg@redhat.com> wrote: > On 03/04, Michel Lespinasse wrote: >> >> Both issues are easily fixed by indicating to lockdep that lglock's local >> locks are not recursive. We shouldn't use the rwlock acquire/release >> functions here, as lglock doesn't share the same semantics. Instead >> we can base our lockdep annotations on the lock_acquire_shared >> (for local lglock) and lock_acquire_exclusive (for global lglock) >> helpers. > > IOW, with this patch lglock looks like rw_semaphore for lockdep...
Yes.
I could have actually made lglock use the rwsem helpers, but I think that would be quite confusing...
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |