lkml.org 
[lkml]   [2013]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] thinkpad-acpi: fix potential suspend blocking issue
From
On Tue, Mar 5, 2013 at 9:48 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 03/05, Mandeep Singh Baines wrote:
>>
>> @@ -2462,13 +2462,13 @@ static int hotkey_kthread(void *data)
>> unsigned int poll_freq;
>> bool was_frozen;
>>
>> + set_freezable();
>> +
>> mutex_lock(&hotkey_thread_mutex);
>>
>> if (tpacpi_lifecycle == TPACPI_LIFE_EXITING)
>> goto exit;
>>
>> - set_freezable();
>> -
>
> I don't understand this code... but don't we have the same problem
> with kthread_freezable_should_stop() below? It can call __refrigerator()
> too under the same lock.
>

I don't think the lock is held at that point. There is an unlock right
before entering the while loop and at the bottom of the loop.

> Oleg.
>


\
 
 \ /
  Last update: 2013-03-05 19:41    [W:0.204 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site