lkml.org 
[lkml]   [2013]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: android: ashmem: Add support for 32bit ashmem calls in a 64bit kernel
On 05/03/13 10:27, Greg KH wrote:
> On Tue, Mar 05, 2013 at 10:18:27AM +0000, Serban Constantinescu wrote:
>> Android's shared memory subsystem, Ashmem, does not support calls from a
>> 32bit userspace in a 64 bit kernel. This patch adds support for syscalls
>> coming from a 32bit userspace in a 64bit kernel.
>>
>> The patch has been successfully tested on ARMv8 AEM(64bit
>> platform model) and Versatile Express A9(32bit platform).
>>
>> Signed-off-by: Serban Constantinescu <serban.constantinescu@arm.com>
>> ---
>> drivers/staging/android/ashmem.c | 22 +++++++++++++++++++++-
>> drivers/staging/android/ashmem.h | 6 ++++++
>> 2 files changed, 27 insertions(+), 1 deletion(-)
>
> Ok, what has changed from your previous version that I rejected that is
> going to actually allow this to build?

I had to add <linux/compat.h> for a successful build on x86_64. The
attached hunk is the only change added.

> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 72064fc..e96f381 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -31,6 +31,7 @@
> #include <linux/bitops.h>
> #include <linux/mutex.h>
> #include <linux/shmem_fs.h>
> +#include <linux/compat.h>
> #include "ashmem.h"
>
> #define ASHMEM_NAME_PREFIX "dev/ashmem/"


>
> Hint, you gotta tell me what version of the patch this is, and what
> changed, otherwise I'll just assume this is a resend of the previous
> patch and go ahead and delete it from my queue.

Sorry - same patch as before, the one that had John and Arve's ack, plus
the above hunk.
>
> In fact, I might as well do that, now deleted :)
>
> greg k-h
>

Thanks,
Serban



\
 
 \ /
  Last update: 2013-03-05 12:21    [W:0.143 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site