lkml.org 
[lkml]   [2013]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/10] dmatest: move dmatest_channels and nr_channels to dmatest_info
From
Date
On Tue, 2013-03-05 at 17:12 +0800, Viresh Kumar wrote: 
> On 4 March 2013 17:09, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > We don't need to have them global and later we would like to protect access to
> > them as well.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/dma/dmatest.c | 29 ++++++++++++++++-------------
> > 1 file changed, 16 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index 7f9e3cc..475a21a 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -109,6 +109,7 @@ struct dmatest_chan {
> > * @timeout: transfer timeout in msec, -1 for infinite timeout
> > */
> > struct dmatest_info {
> > + /* Test parameters */
> > unsigned int buf_size;
> > char channel[20];
> > char device[20];
> > @@ -118,17 +119,14 @@ struct dmatest_info {
> > unsigned int xor_sources;
> > unsigned int pq_sources;
> > int timeout;
> > +
> > + /* Internal state */
> > + struct list_head channels;
> > + unsigned int nr_channels;
> > };
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> What about merging this patch with the patch which added this structure.

As I said in cover letter I believe that few patches could be merged,
but I would like to discuss the main point first.


--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy


\
 
 \ /
  Last update: 2013-03-05 11:01    [W:0.125 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site