Messages in this thread | | | Date | Tue, 5 Mar 2013 11:41:12 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH 2/3] irq: Add hw continuous IRQs map to virtual continuous IRQs support |
| |
On Tue, Jan 15, 2013 at 03:38:55PM +0800, Mike Qiu wrote: > Adding a function irq_create_mapping_many() which can associate > multiple MSIs to a continous irq mapping. > > This is needed to enable multiple MSI support for pSeries. > > +int irq_create_mapping_many(struct irq_domain *domain, > + irq_hw_number_t hwirq_base, int count) > +{
Other than the other review comments already made, I think you can simplify this considerably by simply doing what irq_create_strict_mappings() does, and relaxing the irq_base requirements.
In any event, as you are creating a new interface, I don't think you want to carry around half of the legacy crap that irq_create_mapping() has to deal with. We made the decision to avoid this with irq_create_strict_mappings() intentionally, too.
| |