lkml.org 
[lkml]   [2013]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[Update][PATCH] PCI / PM: Disable runtime PM of PCIe ports
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    The runtime PM of PCIe ports turns out to be quite fragile, as in
    some cases things work while in some other cases they don't and we
    don't seem to have a good way to determine whether or not they are
    going to work in advance.

    For this reason, avoid enabling runtime PM for PCIe ports by
    keeping their runtime PM reference counters always above 0 for the
    time being.

    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    ---

    This version also removes the no longer necessary (and empty anyway)
    port_runtime_pm_black_list[] table.

    Thanks,
    Rafael

    ---
    drivers/pci/pcie/portdrv_pci.c | 13 -------------
    1 file changed, 13 deletions(-)

    Index: linux-pm/drivers/pci/pcie/portdrv_pci.c
    ===================================================================
    --- linux-pm.orig/drivers/pci/pcie/portdrv_pci.c
    +++ linux-pm/drivers/pci/pcie/portdrv_pci.c
    @@ -185,14 +185,6 @@ static const struct dev_pm_ops pcie_port
    #endif /* !PM */

    /*
    - * PCIe port runtime suspend is broken for some chipsets, so use a
    - * black list to disable runtime PM for these chipsets.
    - */
    -static const struct pci_device_id port_runtime_pm_black_list[] = {
    - { /* end: all zeroes */ }
    -};
    -
    -/*
    * pcie_portdrv_probe - Probe PCI-Express port devices
    * @dev: PCI-Express port device being probed
    *
    @@ -225,16 +217,11 @@ static int pcie_portdrv_probe(struct pci
    * it by default.
    */
    dev->d3cold_allowed = false;
    - if (!pci_match_id(port_runtime_pm_black_list, dev))
    - pm_runtime_put_noidle(&dev->dev);
    -
    return 0;
    }

    static void pcie_portdrv_remove(struct pci_dev *dev)
    {
    - if (!pci_match_id(port_runtime_pm_black_list, dev))
    - pm_runtime_get_noresume(&dev->dev);
    pcie_port_device_remove(dev);
    pci_disable_device(dev);
    }


    \
     
     \ /
      Last update: 2013-03-31 00:21    [W:5.108 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site