Messages in this thread | | | Date | Sat, 30 Mar 2013 21:13:52 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void |
| |
Hi Lars,
On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: > Currently i2c_del_adapter() returns 0 on success and potentially an error code > on failure. Unfortunately this doesn't mix too well with the Linux device driver > model. (...)
I see:
struct device_driver { (...) int (*probe) (struct device *dev); int (*remove) (struct device *dev);
So the driver core does allow remove functions to return an error. Are you going to fix all subsystems as you are doing for i2c now, and then change device_driver.remove to return void? If not, I don't see the point of changing it in i2c.
-- Jean Delvare
| |