lkml.org 
[lkml]   [2013]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V3] spi: tegra114: add spi driver
Date
On Fri, 22 Feb 2013 19:59:11 +0530, Manish Badarkhe <badarkhe.manish@gmail.com> wrote:
> On Fri, Feb 22, 2013 at 6:07 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> > Add SPI driver for NVIDIA's Tegra114 SPI controller. This controller
> > is different than the older SoCs SPI controller in internal design as
> > well as register interface.
> >
> > This driver supports the:
> > - non DMA based transfer for smaller transfer i.e. less than FIFO depth.
> > - APB DMA based transfer for lager transfer i.e. more than FIFO depth.
>
> s/lager/larger

Applied, thanks. And I fixed up the typo when I did.

> > + spi_irq = platform_get_irq(pdev, 0);
> > + tspi->irq = spi_irq;
> > + ret = request_threaded_irq(tspi->irq, tegra_spi_isr,
> > + tegra_spi_isr_thread, IRQF_ONESHOT,
> > + dev_name(&pdev->dev), tspi);
>
> Can we use devm_request_threaded_irq instead? to save some code.

I don't have any quams about applying it as-is. That can be done as a
follow on patch.

g.



\
 
 \ /
  Last update: 2013-03-03 13:41    [W:0.069 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site