lkml.org 
[lkml]   [2013]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 044/153] ALSA: rme32.c irq enabling after spin_lock_irq
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Denis Efremov <yefremov.denis@gmail.com>

    commit f49a59c4471d81a233e09dda45187cc44fda009d upstream.

    According to the other code in this driver and similar
    code in rme96 it seems, that spin_lock_irq in
    snd_rme32_capture_close function should be paired
    with spin_unlock_irq.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/pci/rme32.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/pci/rme32.c
    +++ b/sound/pci/rme32.c
    @@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struc
    spin_lock_irq(&rme32->lock);
    rme32->capture_substream = NULL;
    rme32->capture_periodsize = 0;
    - spin_unlock(&rme32->lock);
    + spin_unlock_irq(&rme32->lock);
    return 0;
    }




    \
     
     \ /
      Last update: 2013-03-04 05:41    [W:2.448 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site