Messages in this thread | | | Date | Sun, 03 Mar 2013 17:47:39 -0500 (EST) | Subject | Re: [PATCH] ircomm: release tty before sleeping potentially indefintely | From | David Miller <> |
| |
From: Sasha Levin <sasha.levin@oracle.com> Date: Sun, 3 Mar 2013 17:35:53 -0500
> ircomm_tty_block_til_ready would hold tty lock while blocking. Since the sleep > might take a long time we can prevent other processes from accessing the tty, > causing hung tasks and a dead tty. > > Diagnosed-by: Peter Hurley <peter@hurleysoftware.com> > Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
But then you invalidate all of the tty state tests made under the lock at the beginning of this function, before enterring the loop. If you drop the lock, those pieces of state could change.
I'm not applying this.
| |