lkml.org 
[lkml]   [2013]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs
Date
Justin, All,

On Friday 01 March 2013 jlec@gentoo.org wrote:
> When building ncurses with --with-termlib several symbols get moved from
> libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
> additionally needs to link with libtinfo.so. Ncurses provides a config script
> (ncurses5-config) or in very recent version even a pkg-config module to assist
> finding ncurses.
>
> The old heuristic for detection of ncurses libs will be extended to the
> pkg-config and the config scripts.
>
> Signed-off-by: Justin Lecher <jlec@gentoo.org>
> ---
> scripts/kconfig/lxdialog/check-lxdialog.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index 8078813..8086874 100644
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -4,6 +4,12 @@
> # What library to link
> ldflags()
> {
> + pkg-config --libs ncursesw 2>/dev/null && exit
> + pkg-config --libs ncurses 2>/dev/null && exit
> + ncursesw5-config --libs 2>/dev/null && exit
> + ncurses5-config --libs 2>/dev/null && exit
> + ncursesw6-config --libs 2>/dev/null && exit
> + ncurses6-config --libs 2>/dev/null && exit

In the light of the different mails on the subject, it appears that the
ncurses*-config script are unreliable: at least one major distribution
(Debian) is broken and, for various reasons, is not gonna fix it, and
all its derivatives (eg. Ubuntu) do suffer from the same deficiency.

I think we should stick to:
- try with pkg-config;
- fallback to the legacy heuristic.

Does using pkg-config fix your use-case?

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'


\
 
 \ /
  Last update: 2013-03-03 22:01    [W:0.275 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site