lkml.org 
[lkml]   [2013]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4] i2c: davinci: update to devm_* API
On Tue, Mar 05, 2013 at 05:14:45PM +0530, Vishwanathrao Badarkhe, Manish wrote:
> Update the code to use devm_* API so that driver
> core will manage resources.
>
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>

Applied the following fix:

> + dev->base = devm_ioremap_resource(&pdev->dev, mem);
> + if (IS_ERR(dev->base)) {
> + r = PTR_ERR(dev->base);
> + dev_err(&pdev->dev, "I2C region already claimed\n");
> + goto err_unuse_clocks;

No dev_err after devm_ioremap_resource. make coccicheck will tell you
about this.

Otherwise: Applied to for-next, thanks!



\
 
 \ /
  Last update: 2013-03-29 13:01    [W:0.035 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site