Messages in this thread | | | Date | Thu, 28 Mar 2013 19:00:54 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot |
| |
On Fri, Mar 29, 2013 at 01:39:04AM +0100, Frederic Weisbecker wrote: > 2013/3/29 Paul Gortmaker <paul.gortmaker@windriver.com>: > > [Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot] On 28/03/2013 (Thu 08:40) Ingo Molnar wrote: > > > >> > >> * Frederic Weisbecker <fweisbec@gmail.com> wrote: > >> > >> > + cpulist_scnprintf(nohz_ext_buf, sizeof(nohz_ext_buf), nohz_extended_mask); > >> > + pr_info("NO_HZ: Experimental full dynticks CPUs: %s.\n", nohz_ext_buf); > >> > >> I'd suggest removing the 'experimental' word. We are not sending anything > >> experimental to Linus: we'll send something that is tested and that we > >> expect to not break anything. (and which we'll fix if it does) > > > > In that case, should we vector a patch through PaulM to clobber these too? > > > > $ git grep xperiment |grep rcu > > kernel/rcutree_plugin.h: printk(KERN_INFO "\tExperimental boot-time adjustment of leaf fanout to %d.\n", rcu_fanout_leaf);
This one has been this way for quite some time. I must confess that I am more inclined to remove this Kconfig option entirely than I am to remove the "Experimental". ;-)
> > kernel/rcutree_plugin.h: pr_info("\tExperimental no-CBs CPUs: %s.\n", nocb_buf); > > kernel/rcutree_plugin.h: pr_info("\tExperimental polled no-CBs CPUs.\n"); > > Hehe, that's indeed what I inspired from ;-)
I guess we can rerun the earlier "how to mark Kconfig options as not yet being ready for 100 million unsuspecting victims^Wusers. ;-)
Then again, I do have the warning at the bottom of the help info, so might be OK removing the "Experimental".
Thanx, Paul
| |