lkml.org 
[lkml]   [2013]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg_*
From
Thanks, Thomas. But I didn't change any formatting. Just do the
substitution in place.
Should I re-format and re-send the patch?

On Thu, Mar 28, 2013 at 10:32 PM, Thomas Graf <tgraf@suug.ch> wrote:
> On 03/28/13 at 12:47am, Hong Zhiguo wrote:
>> diff --git a/net/ipv4/udp_diag.c b/net/ipv4/udp_diag.c
>> index 505b30a..467fb92 100644
>> --- a/net/ipv4/udp_diag.c
>> +++ b/net/ipv4/udp_diag.c
>> @@ -64,9 +64,9 @@ static int udp_dump_one(struct udp_table *tbl, struct sk_buff *in_skb,
>> goto out;
>>
>> err = -ENOMEM;
>> - rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) +
>> - sizeof(struct inet_diag_meminfo) +
>> - 64)), GFP_KERNEL);
>> + rep = nlmsg_new(sizeof(struct inet_diag_msg) +
>> + sizeof(struct inet_diag_meminfo) + 64,
>> + GFP_KERNEL);
>
> This is formatted incorrectly, otherwise the patch looks good.



--
best regards
Hong Zhiguo


\
 
 \ /
  Last update: 2013-03-28 17:21    [W:0.637 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site