Messages in this thread | | | Date | Wed, 27 Mar 2013 16:41:02 +0100 | Subject | Re: [RFC] fsfreeze: moving from uniterruptible to killable | From | Marco Stornelli <> |
| |
2013/3/27 Jan Kara <jack@suse.cz>: > On Wed 27-03-13 12:39:10, Marco Stornelli wrote: >> 2013/3/26 Jan Kara <jack@suse.cz>: >> > On Sun 24-03-13 10:10:59, Marco Stornelli wrote: >> >> When a fs is frozen, a process can hang because we wait in >> >> uniterruptible state. We give the user the possibility to kill the process. >> > Yes, but it needs slightly more work as you probably know... (bailing out >> > properly when the signal arrives). >> > >> > Honza >> > >> >> Of course, indeed, it was only an RFC to start a discussion, not a >> patch :) The point was: is this kind of change a behaviour that can >> break user-space in some way? IMHO no, but I'd like to have a >> discussion about that before to start coding. What do you think? > Killable wait is almost always safe WRT to userspace breakage. In this > case I cannot see how it could matter. That's why I agree it's a good thing > to do. > > Honza
Yes, I quite agree. I'll try to look at it in a deeply way.
Regards,
Marco
| |