Messages in this thread | | | Date | Wed, 27 Mar 2013 14:00:01 +0100 | Subject | Re: [PATCH] gpio: palmas: add dt support | From | Linus Walleij <> |
| |
On Thu, Mar 21, 2013 at 3:30 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> #ifdef CONFIG_OF_GPIO > - palmas_gpio->gpio_chip.of_node = palmas->dev->of_node; > + palmas_gpio->gpio_chip.of_node = pdev->dev.of_node; > #endif
OK I think that #ifdef is necessary...
> +#ifdef CONFIG_OF > +static struct of_device_id of_palmas_gpio_match[] = { > + { .compatible = "ti,palmas-gpio"}, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, of_palmas_gpio_match); > +#endif
But please drop the #ifdef here unless it causes compile errors (I don't think it will.)
Yours, Linus Walleij
| |